New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
all-packages.nix: introduce and use dontRecurseIntoAttrs
#56105
Conversation
also /cc @7c6f434c, as usual |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I like the idea behind it, so 👍
(as a side note: unless I'm missing something, you also want to apply dontRecurseIntoAttrs
on weechatScripts
and roundcubePlugins
. I'm "responsible" for both sub-packages and intentionally skipped the recurseIntoAttrs
there).
Is it possible to have documentation on when one would expect to use Not necessarily asking the documentation in the contribution, but at least comments to the PR explaining, so it can be referenced for future documentation. I think it's easier to grok by looking at #45841, where Thanks! |
cc3c0a9
to
8f86439
Compare
Thanks, the comment is good. (I also now fully realize what the comment meant previously.) |
Hmmm. This may even be already enough to support an overlay that does the «maybe» part outside of the main codebase. |
ping? |
In case anyone else is coming here from Google,
|
This pull request has been mentioned on NixOS Discourse. There might be relevant details there: https://discourse.nixos.org/t/wheres-the-nodejs-apps/12064/10 |
What? Why?
The first non-controversial noop commit of #45841. I find this thing very useful: it provides a single place you need to override to make
nix-env -qaP
evaluate all packages, which is very useful for testing.I got tired of rebasing it and fixing conflicts all the time. Can we have it in nixpkgs too, please?
git log
dontRecurseIntoAttrs
nix-instantiate
environmentnix-env -qaP
diffs