Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

ktouch: fix build failure due to dependecy missing #56103

Merged
merged 1 commit into from Feb 22, 2019
Merged

ktouch: fix build failure due to dependecy missing #56103

merged 1 commit into from Feb 22, 2019

Conversation

schmittlauch
Copy link
Member

fixes #56097

Motivation for this change

ktouch failed to build on unstable due to a missing dependency

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@schmittlauch
Copy link
Member Author

@vcunat When I first packaged ktouch I did that for unstable, and back then it actually did build. But whatever, this here should fix it.

@schmittlauch
Copy link
Member Author

@GrahamcOfBorg build ktouch

@vcunat
Copy link
Member

vcunat commented Feb 21, 2019

I can confirm it now builds on both our linux platforms. I suppose there was some significant change on master between the PR being filed and merged.

Does it run for you? For me it exits with

can't find resource: "schemata/data.xsd"

but I do know some KDE won't run for me due to not having Plasma installed system-wide. In any case, this PR seems a strict improvement.

@schmittlauch
Copy link
Member Author

Does it run for you? For me it exits with

can't find resource: "schemata/data.xsd"

KTouch is one of the Qt applications heavily suffering from environment impurities. It needs to be installed into your user/ system environment, e.g. using nix-env. nix-shell alone does not suffice.
I verified that this KTouch build runs correctly when installed using nix-env

vcunat
vcunat approved these changes Feb 22, 2019
View reviewed changes
Copy link
Member

@vcunat vcunat left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Tested via nix-env -i.

Nitpick: I can't find out how to change lessons to a different layout/language, but I had trained with ktouch in some 4.x version IIRC so perhaps I'm just missing something obvious...

@vcunat vcunat merged commit f9dab19 into NixOS:master Feb 22, 2019
vcunat added a commit that referenced this pull request Feb 22, 2019
@vcunat
Merge #56103: ktouch: fix build failure
19eedaf
@schmittlauch schmittlauch deleted the ktouch branch February 22, 2019 16:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@vcunat vcunat vcunat approved these changes

@ttuegel ttuegel Awaiting requested review from ttuegel

Assignees
No one assigned
Labels
6.topic: qt/kde 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

ktouch 18.12.0 not building
3 participants
@schmittlauch @vcunat @GrahamcOfBorg