owncloud-client: 2.4.3 -> 2.5.3.11470 #56114
Conversation
|
If you add the build into the version as one string, it will keep working. |
Is it acceptable to become part of the derivation name (currently defined as |
|
I think that's fine. Arch, Gento, and Debian consider it to be part of the version https://repology.org/metapackage/owncloud-client/versions |
das-g
force-pushed
the
owncloud-client-2.5.3
branch
from
396f3c7 to
57fe61c
Compare
das-g
force-pushed
the
owncloud-client-2.5.3
branch
from
57fe61c to
22c7c4b
Compare
das-g
changed the title
|
OK, I've adapted the PR accordingly. |
|
Looks good! @GrahamcOfBorg build owncloud-client |
|
@GrahamcOfBorg build owncloud-client |
|
Darwin was already failing before this change. |
|
Should this be backported to NixOS 18.09? I didn't see anything blatantly security-related when glancing over the release notes, but lots of crashes seem to have been fixed. (Which of these already affected 2.4.3, and which only later versions we now skipped, I don't know.) |
|
I think we can skip it. It will be in 19.03. If someone really wants it in 18.09, they can ask for it and say why they need it. |
Motivation for this change
latest stable according to https://owncloud.com/download/
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)Unfortunately, source download URLs without build numbers or whatever these are don't seem to be available for versions after 2.4.3, so I guess we won't have automatic updates by @r-ryantm for this package anymore?(see comments below)