Skip to content

libgcc: fix build on darwin #56116

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Closed
wants to merge 1 commit into from
Closed

libgcc: fix build on darwin #56116

wants to merge 1 commit into from
+29 −27

Conversation

matthewbauer
Copy link
Member

Fixes #55197.

@GrahamcOfBorg GrahamcOfBorg added 6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10 labels Feb 21, 2019
Ericson2314
Ericson2314 reviewed Feb 21, 2019
View reviewed changes
Copy link
Member

@Ericson2314 Ericson2314 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you make a gccStdenvNoLibs and pass that in instead? I'd like this to continue to serve as a foundation for better bootstrapping; i.e. it can be built before libc.

@matthewbauer
Copy link
Member Author

I guess so... It doesn't really make sense to use it for bootstrapping on Darwin if it's gcc-only. But we could do something like this:

libgcc = callPackage ../development/libraries/gcc/libgcc {
  stdenv = if stdenv.cc.isGNU then stdenvNoLibs else gccStdenv;
};

@matthewbauer matthewbauer deleted the fix-libgcc branch February 24, 2019 07:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Ericson2314 Ericson2314

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@matthewbauer @Ericson2314 @GrahamcOfBorg