Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

luajit, lmdb: cross-compilation fixes #56143

Merged
merged 3 commits into from Feb 26, 2019
Merged

luajit, lmdb: cross-compilation fixes #56143

merged 3 commits into from Feb 26, 2019

Conversation

vcunat
Copy link
Member

@vcunat vcunat commented Feb 21, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of some pkgs that depend on this change
  • Tested execution of all binary files (usually in ./result/bin/)
  • N/A Determined the impact on package closure size (by running nix path-info -S before and after)
  • N/A Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@vcunat
Copy link
Member Author

vcunat commented Feb 21, 2019

@GrahamcOfBorg build luajit lmdb

@vcunat
Copy link
Member Author

vcunat commented Feb 21, 2019

@GrahamcOfBorg build luajit lmdb

thoughtpolice
thoughtpolice approved these changes Feb 21, 2019
View reviewed changes
Copy link
Member

@thoughtpolice thoughtpolice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@vcunat
Copy link
Member Author

vcunat commented Feb 21, 2019

Uh, I forgot to look at the darwin build result and I can't find it now anymore :-/
@GrahamcOfBorg build luajit lmdb

@Mic92 Mic92 mentioned this pull request Feb 22, 2019
Closed
13 tasks
@7c6f434c
Copy link
Member

@vcunat apparently success on all three platofrms now.

@vcunat
Copy link
Member Author

vcunat commented Feb 23, 2019

Yes, and after the glibc fix (unmerged) even cross-builds succeed. Well, except for the pointer-size limitation in luajit, as I didn't find a sane way of expressing that in nixpkgs ATM and not all HW can even do that... but i686->armv7 cross built for me :-)

I actually don't even need any cross-builds; it's... mainly curiosity or something.

vcunat added a commit that referenced this pull request Feb 26, 2019
@vcunat
Merge #56143: luajit, lmdb, knot-resolver: cross-fixes
07e2b59 
Master commit: e52396c.  It's bugfixes, basically.
@vcunat vcunat merged commit 98385ff into NixOS:master Feb 26, 2019
vcunat added a commit that referenced this pull request Feb 26, 2019
@vcunat
Merge #56143: luajit, lmdb, knot-resolver: cross-fixes
e52396c
@vcunat vcunat deleted the p/cross-luajit-lmdb branch February 26, 2019 14:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@matthewbauer matthewbauer matthewbauer left review comments

@Mic92 Mic92 Mic92 left review comments

@andir andir Awaiting requested review from andir

@thoughtpolice thoughtpolice Awaiting requested review from thoughtpolice

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 101-500 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
6 participants
@vcunat @7c6f434c @thoughtpolice @matthewbauer @Mic92 @GrahamcOfBorg