-
-
Notifications
You must be signed in to change notification settings - Fork 947
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Feature: Game setting to define how industries with neutral stations accept and supply cargo from/to surrounding stations. #7234
Conversation
I definitely like this better than #7204, it avoids propagating the concern into the base tile acceptance query function. And there's a savegame upgrade anyway for the setting, so no real additional complexity for adding another field. |
@nielsmh Less lines added as well (although many were comments), and less tile iterating, for a tiny memory cost. |
I am thinking about changing this to store IDs rather than pointers, depending on how the values are used it may make more sense. |
6274fe9
to
16157e9
Compare
dcd0696
to
f5c5f56
Compare
Thinking about this, I'm tempted to say the default should be the new behviour, with the option there to allow the old 'broken' behaviour. |
Any more needs to be done on this, apart from fix saveload.h? |
f5c5f56
to
f6b21fe
Compare
I believe it is complete, but as usual more eyes are better. It had bugfix commits which have already been squashed. |
f6b21fe
to
83e0599
Compare
Sorry, saveload conflict. |
…accept cargo to/from their neutral station. This change is a controlled by a game setting, located under Environment -> Industries which allows toggling the behaviour. It defaults to enabled. "Company stations can serve industries with attached neutral stations" When enabled, industries with attached neutral station (such as Oil Rigs) may also be served by company-owned stations built nearby. This is the traditional behaviour. When disabled, these industries may only be served by their neutral station. Any nearby company-owned stations won't be able to serve them, nor will the neutral station serve anything else other than the industry.
83e0599
to
d031048
Compare
…accept cargo to/from their neutral station. (OpenTTD#7234) This change is a controlled by a game setting, located under Environment -> Industries which allows toggling the behaviour. It defaults to enabled. "Company stations can serve industries with attached neutral stations" When enabled, industries with attached neutral station (such as Oil Rigs) may also be served by company-owned stations built nearby. This is the traditional behaviour. When disabled, these industries may only be served by their neutral station. Any nearby company-owned stations won't be able to serve them, nor will the neutral station serve anything else other than the industry.
…accept cargo to/from their neutral station. (OpenTTD#7234) This change is a controlled by a game setting, located under Environment -> Industries which allows toggling the behaviour. It defaults to enabled. "Company stations can serve industries with attached neutral stations" When enabled, industries with attached neutral station (such as Oil Rigs) may also be served by company-owned stations built nearby. This is the traditional behaviour. When disabled, these industries may only be served by their neutral station. Any nearby company-owned stations won't be able to serve them, nor will the neutral station serve anything else other than the industry.
Based on #7204 but done by keeping a direct two-way reference between industry and station. This removes associated tile loops to determine where neutral stations are linked.