Change: Make OPF check reverse only when exiting depot #7071
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This change will prevent OPF ships from reversing on open water, though, which in my opinion, does make it look good. Results from testings indicate about 1/3 less cpu usage with this change.
|
Thanks. Same comment as I made on #7070. I think it's counter-productive to extend a dead pathfinder, it's testing and maintenance burden, and the possibility of introducing new issues for zero benefit. That's just my view, others might differ. |
|
Closing this thanks. OPF is intended to be as close to the original path finder as possible (given all the extensions OTTD has over TTD), so even subjectively undesirable behaviour should be kept. Pathfinder improvements should be focussed at YAPF in most cases. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change will prevent OPF ships from reversing on open water, though, which in my opinion, does make it look good.
Results from testings indicate about 1/3 less cpu usage with this change.