Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

youtube-dl: Change to ffmpeg_4 #54320

Merged
merged 1 commit into from Jan 20, 2019
Merged

Conversation

adisbladis
Copy link
Member

@adisbladis adisbladis commented Jan 19, 2019

Motivation for this change

This is to reduce the closure size of mpv which wraps youtube-dl

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @bluescreen303 @Phreedom @AndersonTorres @Fuuzetsu @fpletz @Enzime

This is to reduce the closure size of mpv which wraps youtube-dl
@worldofpeace
Copy link
Contributor

Can we get this in 18.09 also?

@adisbladis
Copy link
Member Author

@worldofpeace I'm reluctant to backport this since I'm not sure about what breakge is going to happen.

@worldofpeace
Copy link
Contributor

@worldofpeace I'm reluctant to backport this since I'm not sure about what breakge is going to happen.

All updates to youtube-dl have already been backported, and I think we're on the same version of ffmpeg in stable as well.

@AndersonTorres
Copy link
Member

OK!

@fpletz fpletz merged commit 0494714 into NixOS:master Jan 20, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants