Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vapi setup hook #54324

Merged
merged 3 commits into from Jan 20, 2019
Merged

Vapi setup hook #54324

merged 3 commits into from Jan 20, 2019

Conversation

jtojnar
Copy link
Contributor

@jtojnar jtojnar commented Jan 19, 2019 •
edited

Motivation for this change

Add datadir containing vapidir to XDG_DATA_DIRS and move vapidir to dev output.

We should be able to compile vala programs without gobject-introspection #54248 (comment)

Also considered #32790 but probably not worth it.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @hedning @worldofpeace

@worldofpeace
Copy link
Contributor

I agree that #32790 (comment) isn't all what it's up to.

cough, staging btw

@jtojnar jtojnar changed the base branch from master to staging January 20, 2019 02:44
@jtojnar
gobject-introspection.setupHook: limit XDG_DATA_DIRS
b766ec2 
The setup hook was adding share directory to XDG_DATA_DIRS variable whenever
it existed, even when gir-1.0 subdirectory did not.
@jtojnar
vala: add setup hook
79ca7f4 
Add datadir containing vapidir to XDG_DATA_DIRS and move vapipdir to dev output.
@jtojnar jtojnar merged commit c622d7d into NixOS:staging Jan 20, 2019
@jtojnar jtojnar deleted the vapi-setup-hook branch January 20, 2019 11:37
@jtojnar jtojnar mentioned this pull request Feb 22, 2019
Merged
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@peterhoeg peterhoeg Awaiting requested review from peterhoeg

Assignees
No one assigned
Labels
10.rebuild-darwin: 501+ 10.rebuild-linux: 501+
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jtojnar @worldofpeace @GrahamcOfBorg @FRidh