Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.zm-py: init at 0.3.0 #54317

Merged
merged 2 commits into from Jan 21, 2019
Merged

pythonPackages.zm-py: init at 0.3.0 #54317

merged 2 commits into from Jan 21, 2019

Conversation

peterhoeg
Copy link
Member

Motivation for this change

And add it to HA - works great here!

Cc: @dotlambda

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@peterhoeg peterhoeg requested a review from FRidh as a code owner January 19, 2019 13:05
dotlambda
dotlambda requested changes Jan 19, 2019
View reviewed changes
Copy link
Member

@dotlambda dotlambda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is not compatible with Python 2.

pkgs/development/python-modules/zm-py/default.nix Outdated
@@ -0,0 +1,24 @@
{ stdenv, fetchPypi, pkgconfig, fetchpatch, fetchFromGitHub, buildPythonPackage
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
{ stdenv, fetchPypi, pkgconfig, fetchpatch, fetchFromGitHub, buildPythonPackage
{ lib, fetchPypi, buildPythonPackage

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Some leftover junk - thanks

pkgs/development/python-modules/zm-py/default.nix Outdated
# tests are not running but really should
doCheck = false;

meta = with stdenv.lib; {
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
meta = with stdenv.lib; {
meta = with lib; {

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Fixed

@dotlambda
Copy link
Member

You removed ac3a1a7.

@peterhoeg
Copy link
Member Author

You removed ac3a1a7.

Sorry, it's getting late here... It's back and thank you!

@peterhoeg peterhoeg merged commit f4e0292 into NixOS:master Jan 21, 2019
@peterhoeg peterhoeg deleted the p/hazm branch March 18, 2019 03:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dotlambda dotlambda dotlambda approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees
No one assigned
Labels
6.topic: python 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@peterhoeg @dotlambda @GrahamcOfBorg