Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

go-ethereum: 1.8.20 -> 1.8.21 #54304

Merged
merged 1 commit into from Jan 19, 2019
Merged

go-ethereum: 1.8.20 -> 1.8.21 #54304

merged 1 commit into from Jan 19, 2019

Conversation

enolan
Copy link
Contributor

@enolan enolan commented Jan 19, 2019 •
edited

Updates the package to track an emergency hotfix release. This fixes a security vulnerability.

From their release notes: Geth 1.8.21 is an emergency hotfix release to postpone the mainnet Constantinople upgrade! The reason is a last minute reentrancy vulnerability dicovered by ChainSecurity.

Tagging: @adisbladis @lionello

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@enolan
go-ethereum: 1.8.20 -> 1.8.21
728384e 
Updates the package to track an emergency hotfix release. This fixes a
security vulnerability.
@adisbladis
Copy link
Member

@GrahamcOfBorg build go-ethereum

@adisbladis adisbladis merged commit 49c0d3a into NixOS:master Jan 19, 2019
@enolan enolan deleted the geth-update branch January 20, 2019 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@enolan @adisbladis @GrahamcOfBorg