Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[18.09] Signal-Desktop backport #54987

Merged
merged 2 commits into from Jan 31, 2019
Merged

[18.09] Signal-Desktop backport #54987

merged 2 commits into from Jan 31, 2019

Conversation

primeos
Copy link
Member

@primeos primeos commented Jan 31, 2019 •
edited

Motivation for this change

The current version will expire in 25 days.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@primeos
signal-desktop: 1.18.1 -> 1.19.0
44fc32d 
A new dependency (at-spi2-atk) is required for libatk-bridge-2.0.so.

Also libstdc++.so.6 is now required from stdenv.cc.cc.lib (stdenv.cc.cc
doesn't offer it). The binary will only find libstdc++.so.6 via
$LD_LIBRARY_PATH (i.e. not via rpath, the run-time search path).

(cherry picked from commit e01209f)
@primeos
signal-desktop: 1.19.0 -> 1.20.0
f9514c9 
(cherry picked from commit 3efab17)
@primeos primeos self-assigned this Jan 31, 2019
@primeos primeos added the 8.has: port to stable A PR already has a backport to the stable release. label Jan 31, 2019
@primeos primeos merged commit 54e78e8 into NixOS:release-18.09 Jan 31, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees

@primeos primeos

Labels
8.has: port to stable A PR already has a backport to the stable release. 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@primeos @GrahamcOfBorg