force pushed a grammar fix :)

I'm not sure if we're allowed to repack that executable. I remember that jagex used to have an open source launcher (which we would be able to unpack, and thus ship in NixOS)

Also, iirc the RuneScape launcher used to self-update. Does this work in NixOS or do we need to keep the launcher up to date often? If it's the latter, it would be nice to have a nice script that detects new releases and generates the nix derivation.

Hmm, yeah I think I should find some clarification on what is and isn't good to redistribute. I think I came across their open source client before, would this be it?

https://github.com/rsu-client/rsu-client

I actually have a nix script that packages it and it mostly works, but the issue I was having is that I couldn't get RS3 to work and felt a bit weird about pushing something that only worked with 1 of the 2 games offered.

From what I understand, Old School Runescape is autoupdated by the appletviewer on launch and the appletviewer we're packaging here isn't updated too much itself, but one of the features I'm seeing of rsu-client here is that it has a script to automatically update to the newest appletviewer, in case Jagex chooses to update that as well. This makes me think that there's a decent possibility this could happen in the future, so I'll look into this a bit more..

Here is the GPL licensed source code: http://www.runescape.com/downloads/jagexlauncher-src.tar.bz2 but i think it's of RS3. Maybe there's one for OSRS too

Edit: sources tell me they use the same launcher.

@MP2E are you motivated to continue with this PR?

I tend to use the 3rd party RuneLite client now which I'm not sure on how to properly package. I didnt get too far repackaging the official gpl launcher, though I just pushed a few tweaks I made to this launcher in the meantime.

Since it's unclear whether this can be distributed with NixOS and I'm probably just going to stick with RuneLite, I'll go ahead and close this PR.