Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zoom-us: 2.6.149990.1216 -> 2.7.162522.0121 #54969

Merged
merged 2 commits into from Feb 1, 2019
Merged

zoom-us: 2.6.149990.1216 -> 2.7.162522.0121 #54969

merged 2 commits into from Feb 1, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Jan 31, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@danbst
Copy link
Contributor

danbst commented Jan 31, 2019

@dtzWill I get this:

[nix-shell:~/.cache/nix-review/pr-54969]$ zoom-us
zoom started.
Segmentation fault

@dtzWill
Copy link
Member Author

dtzWill commented Jan 31, 2019 via email

@danbst
Copy link
Contributor

danbst commented Feb 1, 2019

bisected down to 776c962

@danbst
Copy link
Contributor

danbst commented Feb 1, 2019

Using strace (strace ./result/bin/zoom-us 2>&1 | grep open | grep -v /nix/store | grep -v ENOENT), found that it makes access to

openat(AT_FDCWD, "/home/danbst/.nix-profile/lib/qt-5.9/plugins/platforms", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 3
openat(AT_FDCWD, "/run/current-system/sw/lib/qt-5.9/plugins/platforms", O_RDONLY|O_NONBLOCK|O_CLOEXEC|O_DIRECTORY) = 3

which itself is linked from /nix/store/9ffpk26yaaxjj9n9717ncsrb2vyppycm-zoom-us-qt-5.9.3/lib/qt-5.9/plugins/platforms.

So, it is indeed trying to use incompatible versions of Qt, left from already installed Zoom.

@danbst danbst mentioned this pull request Feb 1, 2019
Merged
10 tasks
@danbst danbst merged commit c8e56dd into NixOS:master Feb 1, 2019
@danbst
Copy link
Contributor

danbst commented Feb 1, 2019

Runs fine in nix-shell --pure with XDG_RUNTIME_DIR=/run/user/1000 LD_LIBRARY_PATH=/run/opengl-driver/lib

@danbst danbst mentioned this pull request Feb 5, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@danbst danbst danbst approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dtzWill @danbst @GrahamcOfBorg