Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

esphome: init at 1.10.1 #53990

Merged
merged 1 commit into from Jan 18, 2019
Merged

esphome: init at 1.10.1 #53990

merged 1 commit into from Jan 18, 2019

Conversation

dotlambda
Copy link
Member

@dotlambda dotlambda commented Jan 15, 2019 •
edited

Motivation for this change

I have not tested this with real hardware yet. This is just a PoC for how to patch esphomeyaml not to import platformio and esptool. See #38571.

Should I put esphomeyaml in pkgs/development/arduino instead?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

cc @peterhoeg @FRidh

@peterhoeg
Copy link
Member

You're a machine!

I will not have time to try this out right now but am definitely going to give this a go.

Couple of minor points:

  1. esphomeyaml is the old name. It's just esphome (or ESPHome)
  2. 1.10.1 was released a few days ago

I think you should keep it under HA.

@dotlambda
Copy link
Member Author

esphomeyaml is the old name. It's just esphome (or ESPHome)

I think there are two components to ESPHome:

  • esphomelib, the C++/Arduino libraries
  • esphomeyaml, for configuring said libraries

I'm packaging the second one.

@peterhoeg
Copy link
Member

  • esphomelib will be called esphomecore
  • esphomeyaml will be esphome

https://esphomelib.com/esphomeyaml/changelog/v1.10.0.html#rename-esphome-lib-yaml-esphome

@dotlambda
Copy link
Member Author

Oh, didn't know that. Thank you!
As the change doesn't seem to have been made yet, I think we should keep the pname as it is but make the package available as pks.esphome.

@dotlambda dotlambda changed the title [WIP] esphomeyaml: init at 1.10.0 [WIP] esphome: init at 1.10.1 Jan 16, 2019
@dotlambda dotlambda mentioned this pull request Jan 16, 2019
Closed
@dotlambda dotlambda changed the title [WIP] esphome: init at 1.10.1 esphome: init at 1.10.1 Jan 17, 2019
@dotlambda
Copy link
Member Author

This seems to work perfectly fine with my ESP8266, even the OTA update.

@peterhoeg
Copy link
Member

LGTM!

@peterhoeg peterhoeg merged commit 4d2a45b into NixOS:master Jan 18, 2019
@dotlambda dotlambda deleted the esphomeyaml-init branch January 17, 2024 05:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@dotlambda @peterhoeg @GrahamcOfBorg