Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix some dead links #53992

Merged
merged 3 commits into from Jan 15, 2019
Merged

Fix some dead links #53992

merged 3 commits into from Jan 15, 2019

Conversation

fgaz
Copy link
Member

@fgaz fgaz commented Jan 15, 2019

Motivation for this change

As reported by repology: https://repology.org/maintainer/francygazz%40gmail.com/problems

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@@ -14,7 +14,7 @@ stdenv.mkDerivation rec {
];

meta = with stdenv.lib; {
homepage = "https://jump.gnu.sinusoid.es/";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

"https://jump.gnu.sinusoid.es/" works perfectly well

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It redirects though

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

(I do not have a strong opinion about this, it's just an url. just tell me if I have to remove that commit)

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should be fine.

@Mic92 Mic92 merged commit 8c3e66e into NixOS:master Jan 15, 2019
@fgaz fgaz deleted the dead-links/1 branch January 15, 2019 19:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants