Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: befac4ae4bdb
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 1f0467005dd4
Choose a head ref
  • 1 commit
  • 1 file changed
  • 1 contributor

Commits on Jan 15, 2019

  1. openblas: 0.3.4 -> 0.3.5, rework a bit (#53972) 

    * openblas: simplify a bit, fix doCheck so tests are enabled non-cross.

* doCheck should be 'true' in (at least) the non-cross case,
  this looks like an inverted check that's largely benign
* doCheck will be set to 'false' in the cross case anyway,
  makeDerivation does this IIRC
* targetPrefix can be used without checking, probably by design

Derivation hash does change but no "real" functionality change intended.

* openblas: nix types for config attrs (hash-preserving)

* openblas: more nix-ification, merge in cross attrs, prefer to always set

(but set appropriately for cross and non-cross cases both)

* I'm not sure what NO_BINARY_MODE does,
  this change now sets explicitly false in the non-cross scenario
  (previously unset unless cross).
* Drop musl NO_AFFINITY case, will be removed in upgrade shortly

* openblas: 0.3.4 -> 0.3.5
    @dtzWill @FRidh
    dtzWill authored and FRidh committed Jan 15, 2019
    Copy the full SHA
    1f04670 View commit details
    Browse the repository at this point in the history