Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
base: 2ea8a2147c7c
Choose a base ref
...
head repository: NixOS/nixpkgs
compare: 57004738b168
Choose a head ref
  • 1 commit
  • 3 files changed
  • 1 contributor

Commits on Jan 15, 2019

  1. bazel: fix python stub paths. 

    Since the 0.21 upgrade, the host `$PATH` is not forwarded anymore by
default to the sandboxes in charge to realize Bazel actions. This
default change broke the `py_binary` rule among other things.

Every python binary is wrapped in a stub in charge to setup the
execution environment. Currently, this stub's shebang points to a
`/usr/bin/env python` which cannot be resolved with the current
`$PATH`.
This results in breaking any build pipeline requiring the use of
python at some point. On top of the incorrect shebang, the stub
template is unable to find the actual python binary using
`SearchPath`.

This PR fixes those two things by re-writing the stub template shebang
to the actual python binary and by substituting the faulty default
python binary lookup to the right one.
    @picnoir @Profpatsch
    picnoir authored and Profpatsch committed Jan 15, 2019
    Copy the full SHA
    5700473 View commit details
    Browse the repository at this point in the history