Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pg_tmp, ephemeralpg: fix on darwin and merge #53995

Merged
merged 3 commits into from Jan 16, 2019
Merged

pg_tmp, ephemeralpg: fix on darwin and merge #53995

merged 3 commits into from Jan 16, 2019

Conversation

yorickvP
Copy link
Contributor

Motivation for this change

pg_tmp and ephemeralpg were both the same package (but pg_tmp was behind). Also, it was failing on darwin, since that doesn't have getopt available globally.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg added the 6.topic: darwin Running or building packages on Darwin label Jan 15, 2019
@yorickvP
Copy link
Contributor Author

(cc: @hrdinka)

hrdinka
hrdinka requested changes Jan 15, 2019
View reviewed changes
pkgs/top-level/all-packages.nix Outdated Show resolved Hide resolved
@hrdinka hrdinka merged commit def5124 into NixOS:master Jan 16, 2019
@hrdinka
Copy link
Contributor

hrdinka commented Jan 16, 2019

Tested locally. Thanks for your contribution 👍

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@hrdinka hrdinka hrdinka approved these changes

Assignees
No one assigned
Labels
6.topic: darwin Running or building packages on Darwin 8.has: clean-up 8.has: package (new) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @hrdinka @GrahamcOfBorg