Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

teamviewer: 13.1.3026 -> 14.1.3399 #54259

Closed
wants to merge 5 commits into from
Closed

teamviewer: 13.1.3026 -> 14.1.3399 #54259

wants to merge 5 commits into from

Conversation

DrWowa
Copy link
Contributor

@DrWowa DrWowa commented Jan 18, 2019 •
edited

teamviewer: 13.1.3026 -> 14.1.3399

Motivation for this change

Update teamviewer from 13.1.3026 to 14.1.3399

Fixes #51059

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests) (not found any)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date (not found any)
  • Fits CONTRIBUTING.md.

@Mic92 Mic92 changed the title Update teamviewer from 13.1.3026 to 14.1.3399 teamviewer: 13.1.3026 -> 14.1.3399 Jan 18, 2019
worldofpeace
worldofpeace suggested changes Jan 18, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@DrWowa You may notice that a maintainer modified your pr title.

That is because it doesn't match the contribution guidelines.
You should also change your commit msg to this.

Aside from that you have performed this update correctly.

@worldofpeace
Copy link
Contributor

Changelog: https://community.teamviewer.com/t5/Linux/Update-14-1-3399-TeamViewer-14/m-p/46523#

We updated our dependencies to Qt 5.5 and might go to 5.6 within the next year. This gives us many new options to create a good UI, and can help us to improve HighDPI suport.
On the other hand, we are aware that some of our customers are still on systems that don't sport Qt 5.5 (or 5.6).

I'm not familiar with qt, but I'd think this might be a problem for stable, as a backport is needed.
@Mic92 Any comments?

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

@worldofpeace that should work as we have qt 5.11 already. Should be tested though.

@worldofpeace
Copy link
Contributor

Currently executes fine on my machine running off of master.

@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

Here is a report that it might segfaults with the latest qt.
#53117

Using libsForQt56 should be a safer choice.

worldofpeace
worldofpeace suggested changes Jan 19, 2019
View reviewed changes
Copy link
Contributor

@worldofpeace worldofpeace left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

In all-packages.nix call teamviewer with libsForQt56.callPackage.

teamviewer = libsForQt56.callPackage ...

@worldofpeace
Copy link
Contributor

Please rebase instead of merging.
See: https://nixos.org/nixpkgs/manual/#submitting-changes-making-patches

@Mic92
Copy link
Member

Mic92 commented Jan 23, 2019 •
edited

merged in:
[detached HEAD 2a858b3] teamviewer: 13.1.3026 -> 14.1.3399
Author: Vladimir Mosienko vm.drwowa@gmail.com
Date: Fri Jan 18 11:39:42 2019 +0500
2 files changed, 4 insertions(+), 4 deletions(-)

@Mic92 Mic92 closed this Jan 23, 2019
@Mic92
Copy link
Member

Mic92 commented Jan 23, 2019

backport: c7ae9a2

@DrWowa DrWowa deleted the teamviewer branch January 23, 2019 10:34
@atopuzov atopuzov mentioned this pull request Feb 6, 2019
Closed
10 tasks
@worldofpeace worldofpeace mentioned this pull request May 7, 2019
Closed
10 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@worldofpeace worldofpeace worldofpeace requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Package update required: Teamviewer 13 -> Teamviewer 14
5 participants
@DrWowa @worldofpeace @Mic92 @GrahamcOfBorg @Janik-Haag