gem-config: support rbnacl v6.0.0 #54262
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
With the v6.0.0 release of the `rbnacl` gem, it does not longer depends on `rbnacl-libsodium` gem (which is now deprecated ([1])) to package the `libsodium` library and should use the one provided by the distribution; it raises an error if `rbnacl-libsodium` is detected ([2]). Unfortunately, default gem config patches `rbnacl` unconditionally ([3]), which means that newer versions of `rbnacl` fail at startup. [1]: RubyCrypto/rbnacl-libsodium#29 [2]: https://github.com/crypto-rb/rbnacl/blob/c176fc0bd8be74cf62c93a4b122e220ce4895348/lib/rbnacl.rb#L4-L8 [3]: https://github.com/NixOS/nixpkgs/blob/9fd099a6ae1690909ebf40145e4cdabd67179676/pkgs/development/ruby-modules/gem-config/default.nix#L300-L306
|
can we have some tests please? |
|
@zimbatm is there any test for gem-config that I can use as a reference? |
|
no, that's the problem, we have all the gem configs but they aren't tested. I am pretty sure some of them are breaking because of that. Anyways, it's not a requirement. I just reacted because that gem config is getting more complicated than most. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
With the v6.0.0 release of the
rbnaclgem, it does not longer depend onrbnacl-libsodiumgem (which is now deprecated (1)) to package thelibsodiumlibrary and should use the one provided by the distribution; it raises an error ifrbnacl-libsodiumis detected (2). Unfortunately, default gem config patchesrbnaclunconditionally (3), which means that newer versions ofrbnaclfail at startup.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)