Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

vmware-horizon-client: init at 4.10.0-11053294 #54260

Closed
wants to merge 5 commits into from
Closed

vmware-horizon-client: init at 4.10.0-11053294 #54260

wants to merge 5 commits into from

Conversation

buckley310
Copy link
Contributor

@buckley310 buckley310 commented Jan 18, 2019 •
edited

First package, I hope I got everything right :)

Motivation for this change

Add a package for VMware's remote desktop client
https://www.vmware.com/go/viewclients

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@buckley310
Copy link
Contributor Author

I have updated the URL which should lock the unpacking script to its current version if they ever did change it.

@buckley310 buckley310 closed this Jun 28, 2019
@fabianhauser
Copy link
Member

I'd still be interested in this 🙂
What is the reason this PR was closed @buckley310?

@buckley310
Copy link
Contributor Author

@fabianhauser Basically I ended up suddenly needing smartcard support, which I could not get working. So I closed this, as i would not be using it, and switched to a dockerized version of the client.

However, the 8.0 release was huge. It is now simpler to package and all the features I need are working.
I actually wrote this less than a week ago and have been using it with no issues:
https://gist.github.com/buckley310/1ae362687cf4712209a094063cf726b2

I have not yet bothered to do a PR for it.

@fabianhauser
Copy link
Member

Would be amazing if you could open a PR :)

@buckley310
Copy link
Contributor Author

@fabianhauser @das-g #96849

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@symphorien symphorien symphorien left review comments

Assignees
No one assigned
Labels
8.has: package (new) 10.rebuild-darwin: 0 10.rebuild-linux: 1-10 12. first-time contribution
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@buckley310 @fabianhauser @symphorien @GrahamcOfBorg @Janik-Haag