New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
azure-storage-python #54261
azure-storage-python #54261
Conversation
Not sure whether this should be separate commits, or 1 single commit? |
How to resolve the setup.py condition on Python 2?
|
Separate ones. And they should have
|
Where do I get |
as an argument |
I'm going to use Just a note |
6aa9183
to
3c40b98
Compare
How do I do this? "Determined the impact on package closure size (by running nix path-info -S before and after)" @dotlambda Edits are all done. |
I changed PR name. |
@dotlambda Strange, how the commit log is on a different order to this PR's commits. I committed azure-storage-nspkg first, but it appears that Github bot is testing the last commit first. |
3c40b98
to
751abf7
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't see any tests for these packages so please disable the check phases with
doCheck = false;
pkgs/development/python-modules/azure-storage-queue/default.nix
Outdated
Show resolved
Hide resolved
Aside from that these all build for me locally. |
b24261d
to
a412123
Compare
All edits done, still don't quite understand why the commit order is different though. |
@CMCDragonkai Sorry, I forgot to tell that we need a comment at every
I'm always forget that one 😄 |
Done. |
a412123
to
8e69913
Compare
8e69913
to
70cd3be
Compare
Thanks again 👍 |
Motivation for this change
This is a set of different packages all from https://github.com/Azure/azure-storage-python
Note that while the set ends up working in Python 3. In Python 2, they require an extra dependency of
futures
. See thesetup.py
of each subpackage. I'm not sure how to make this work.Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)