Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We鈥檒l occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

zfsUnstable: 0.8.0-rc2 -> 0.8.0-rc3 #54258

Merged
merged 2 commits into from Jan 30, 2019
Merged

zfsUnstable: 0.8.0-rc2 -> 0.8.0-rc3 #54258

merged 2 commits into from Jan 30, 2019

Conversation

aij
Copy link
Contributor

@aij aij commented Jan 18, 2019 •
edited

Motivation for this change

Upgrade

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.
  • Tested boot on real hardware. 馃槂

The extra --with-python configure flag is needed to get around zfsonlinux/zfs!8300 .

dotlambda
dotlambda requested changes Jan 18, 2019
View reviewed changes
pkgs/os-specific/linux/zfs/default.nix Outdated Show resolved Hide resolved
pkgs/os-specific/linux/zfs/default.nix Outdated Show resolved Hide resolved
@Mic92
Copy link
Member

Mic92 commented Jan 18, 2019

The test also succeeded locally.

@aij
Copy link
Contributor Author

aij commented Jan 30, 2019

@dotlambda Anything else?

@dotlambda
Copy link
Member

I'll test this on real hardware within the next 24 hours.
@Mic92 Feel free to merge if you already did so.

@Mic92 Mic92 merged commit 73fda89 into NixOS:master Jan 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Mic92 Mic92 Mic92 left review comments

@dotlambda dotlambda dotlambda requested changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 11-100
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@aij @Mic92 @dotlambda @GrahamcOfBorg