Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Remove ability for SDL to be dynamically loaded on Windows #7308

Merged
merged 1 commit into from Mar 2, 2019

Conversation

TrueBrain
Copy link
Member

@TrueBrain TrueBrain commented Mar 2, 2019

This was introduced very early in OpenTTD; we used to ship SDL.dll next to openttd.exe. Given we no longer use SDL for stable releases, this has become obsolete.

SDL still works on Windows, you just need to make sure you have SDL installed yourself.

Copy link
Member

@LordAro LordAro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does this count as reviewing my own PR? :p

@TrueBrain TrueBrain merged commit c3bc7d6 into OpenTTD:master Mar 2, 2019
@TrueBrain TrueBrain deleted the sdl_dyn branch March 2, 2019 16:13
LordAro added a commit to LordAro/OpenTTD that referenced this pull request Mar 3, 2019
And also static build with SDL generally. And a zlib variable that was wrong
LordAro added a commit to LordAro/OpenTTD that referenced this pull request Mar 3, 2019
LordAro added a commit that referenced this pull request Mar 3, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants