xsecurelock: Added missing X11 buildInputs #56630
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
According to xsecurelock's configure.ac file, each of the add dependencies are used to: - libXrandr: XRandR provides information about monitor layouts and is strongly recommended on systems which can use more than one monitor (which includes most laptops). - libXext: The X Synchronization extension is used to get per-device idle times. Used by until_nonidle only. - libXScrnSaver: The X11 Screen Saver extension is used to turn off the screen saver when X11 handles screen blanking (e.g. via timeout) anyway. Saves CPU power. Adding libXrandr fixes an issue where locking a screen in a multi monitor setup results in the prompt information to not be in the middle of the screen. The other dependencies are not tested if they fixed something, however since upstream recommends than I think it is fair to include them also.
thiagokokada
added a commit
to thiagokokada/dotfiles
that referenced
this pull request
Mar 2, 2019
Should be removed after PR NixOS/nixpkgs#56630 is merged.
|
@GrahamcOfBorg build xsecurelock |
|
Thanks for noticing and fixing this! I'm using xss-lock to activate xsecurelock so I didn't run into that. |
|
@fpletz Thanks for the fast merge! Can this change be included in 19.03? Or is it too late? |
|
Thanks for the reminder. I had already cherry-picked it to 19.03 but didn't push it yet because I had some other cherry-picks I was testing. Pushed as 8850144. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
According to xsecurelock's
configure.acfile, each of the add dependencies are used to:until_nonidleonly.Adding libXrandr fixes an issue where locking a screen in a multi monitor setup results in the prompt information to not be in the middle of the screen. The other dependencies are not tested if they fixed something, however since upstream recommends then I think it is fair to include them also.
nix path-info
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)