Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.pypandoc: 1.4 -> 2019-03-01 #56592

Closed
wants to merge 1 commit into from
Closed

pythonPackages.pypandoc: 1.4 -> 2019-03-01 #56592

wants to merge 1 commit into from

Conversation

Twey
Copy link
Contributor

@Twey Twey commented Mar 1, 2019

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@Twey Twey requested a review from FRidh as a code owner March 1, 2019 20:22
FRidh
FRidh reviewed Mar 2, 2019
View reviewed changes
pkgs/development/python-modules/pypandoc/default.nix
src = fetchFromGitHub {
owner = "bebraw";
repo = "pypandoc";
rev = "87912f0f17e0a71c1160008df708c876d32e5819";
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why a seemingly arbitrary commit?

@Twey
Copy link
Contributor Author

Twey commented Mar 2, 2019

It's just the head of master at the time, and works with the version of Pandoc we have in nixpkgs. We can bump it to a release next time it releases, but until then there's not much point having the released version around when it doesn't work.

@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

It's worth mentioning the choice of some revision in the code.

@dotlambda
Copy link
Member

87912f is from 2018-06-18. You might also want to prefix the version with unstable-.

@aanderse
Copy link
Member

@Twey It looks like you're really close to a merge. If you can address the comments above, specifically about adding a comment on choice of revision and the version string I'm sure everyone would be happy to commit.

PS. from the nixpkgs manual, regarding version string:

If a package is not a release but a commit from a repository, then the version part of the name must be the date of that (fetched) commit. The date must be in "YYYY-MM-DD" format. Also append "unstable" to the name - e.g., "pkgname-unstable-2014-09-23".

@sternenseemann
Copy link
Member

Would be great to get this merged soon as I am currently trying to a package that depends on pypandoc.

@sternenseemann sternenseemann mentioned this pull request Dec 17, 2019
Merged
10 tasks
sternenseemann added a commit to sternenseemann/nixpkgs that referenced this pull request Dec 27, 2019
@sternenseemann
pythonPackages.pypandoc: 1.4 -> 2018-06-18
0353324 
Switch to an unstable version to make it work with pandoc v2.

Based on NixOS#56592 by @Twey. Reworked dependency handling.
bennofs pushed a commit that referenced this pull request Jan 18, 2020
@sternenseemann @bennofs
pythonPackages.pypandoc: 1.4 -> 2018-06-18
6b6e54e 
Switch to an unstable version to make it work with pandoc v2.

Based on #56592 by @Twey. Reworked dependency handling.
@bennofs
Copy link
Contributor

bennofs commented Jan 18, 2020

pypandoc update was merged with #75840

@bennofs bennofs closed this Jan 18, 2020
dtzWill pushed a commit to dtzWill/nixpkgs that referenced this pull request Jan 19, 2020
@sternenseemann @dtzWill
pythonPackages.pypandoc: 1.4 -> 2018-06-18
b033ebe 
Switch to an unstable version to make it work with pandoc v2.

Based on NixOS#56592 by @Twey. Reworked dependency handling.

(cherry picked from commit 6b6e54e)
cript0nauta pushed a commit to infobyte/nixpkgs that referenced this pull request Apr 8, 2020
@sternenseemann @cript0nauta
pythonPackages.pypandoc: 1.4 -> 2018-06-18
dbafc88 
Switch to an unstable version to make it work with pandoc v2.

Based on NixOS#56592 by @Twey. Reworked dependency handling.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@FRidh FRidh FRidh left review comments

@bennofs bennofs Awaiting requested review from bennofs

Assignees
No one assigned
Labels
6.topic: python 8.has: documentation 8.has: package (update) 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
8 participants
@Twey @FRidh @dotlambda @aanderse @sternenseemann @bennofs @infinisil @GrahamcOfBorg