Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nodePackages.indium: init at 3.4.1 #56594

Merged
merged 1 commit into from Mar 22, 2019
Merged

nodePackages.indium: init at 3.4.1 #56594

merged 1 commit into from Mar 22, 2019

Conversation

terlar
Copy link
Contributor

@terlar terlar commented Mar 1, 2019

Motivation for this change

Add package for Indium a JavaScript development environment for Emacs.
https://indium.readthedocs.io/en/latest/index.html

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@terlar
Copy link
Contributor Author

terlar commented Mar 21, 2019

I re-based this as it had become stale with merge conflicts due to newer packages being merged. Should be ready to go again.

@Mic92 Mic92 merged commit b748190 into NixOS:master Mar 22, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 22, 2019

Thanks!

@terlar terlar deleted the add-node-package-indium branch March 22, 2019 12:34
@dotlambda dotlambda mentioned this pull request Aug 20, 2023
Merged
12 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@terlar @Mic92 @GrahamcOfBorg