Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

geoclue2: 2.5.1 -> 2.5.2 #56637

Merged
merged 2 commits into from Mar 4, 2019
Merged

Conversation

worldofpeace
Copy link
Contributor

Motivation for this change

https://gitlab.freedesktop.org/geoclue/geoclue/blob/2.5.2/NEWS

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@7c6f434c
Copy link
Member

7c6f434c commented Mar 2, 2019

Hm. So xdg-desktop-portal still doesn't like that geoclue2?

@worldofpeace
Copy link
Contributor Author

Hm. So xdg-desktop-portal still doesn't like that geoclue2?

Or maybe I forgot to add it as a buildInputs 😄

@worldofpeace
Copy link
Contributor Author

@GrahamcOfBorg build nixosTests.xdg-desktop-portal

@worldofpeace worldofpeace merged commit 20aeed3 into NixOS:master Mar 4, 2019
@worldofpeace worldofpeace deleted the geoclue/2.5.2 branch March 4, 2019 05:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants