Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

azure-mgmt-*: re-init older versions for use with nixops #56775

Merged
merged 1 commit into from Mar 3, 2019

Conversation

bendlas
Copy link
Contributor

@bendlas bendlas commented Mar 3, 2019

add pinned versions package-private

azure-mgmt-compute 0.20.1
azure-mgmt-network 0.20.1
azure-mgmt-nspkg 1.0.0
azure-mgmt-resource 0.20.1
azure-mgmt-storage 0.20.0

replacement for #52550

Motivation for this change

nixops is incompatible with the most recent versions of listed
azure-mgmt-* packages, therefore we should pin them to
package-private versions, so that they don't get trampled by
updates, while NixOS/nixops#1065 is fixed.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

add pinned versions package-private

azure-mgmt-compute 0.20.1
azure-mgmt-network 0.20.1
azure-mgmt-nspkg 1.0.0
azure-mgmt-resource 0.20.1
azure-mgmt-storage 0.20.0

NixOS#52550
NixOS/nixops#1065
@bendlas bendlas requested a review from FRidh March 3, 2019 09:40
@bendlas
Copy link
Contributor Author

bendlas commented Mar 3, 2019

Actually, the updated builds for azure-mgmt-* are failing (in addition to nixops being incompatible with that release), so I'll merge this right away, in order to restore nixops to a working state. Instead, I'll re-open the PR, fixing the newer releases ...

@flokli
Copy link
Contributor

flokli commented Mar 6, 2019

backported to 19.03 in 17a5b64.

@tomberek
Copy link
Contributor

This seems to work for nixopsUnstable as well.

@bendlas bendlas deleted the fix-nixops branch October 22, 2023 02:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants