Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

llvm8: init #56645

Merged
merged 1 commit into from Mar 4, 2019
Merged

llvm8: init #56645

merged 1 commit into from Mar 4, 2019

Conversation

matthewbauer
Copy link
Member

Motivation for this change

Mostly just copied from llvm 7.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@matthewbauer
Copy link
Member Author

@dtzWill is it okay to merge this before the release just for testing, etc.?

@dtzWill
Copy link
Member

dtzWill commented Mar 4, 2019 via email

@matthewbauer matthewbauer merged commit 7874ca5 into NixOS:master Mar 4, 2019
@Kaali Kaali mentioned this pull request Mar 13, 2019
10 tasks
@rrbutani rrbutani mentioned this pull request Jan 8, 2023
92 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants