-
-
Notifications
You must be signed in to change notification settings - Fork 15.5k
mailcatcher: 0.6.5 -> 0.7.1 #56575
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
mailcatcher: 0.6.5 -> 0.7.1 #56575
Conversation
@zarelit looking good. I just built your branch locally and ran it on NixOS stable, all good. Tested both the executable files provided and everything functioned as expected. Do you have any interest in adding a module for this? A module would be pretty convenient for test boxes, plus a NixOS test would make confirmation the package is working automatic and easier for merging. |
@aanderse Thank you for the review! |
Local testing primarily, but redirecting mail that all the test copy of production web sites on my nixops dev network generates, and then giving developers who use the network access to the mailcatcher web ui might be useful too. If you end up writing a test and/or module please ping me as I'm interested. |
So I started talking to the guys at work and realized this would have way more value than I initially thought. Pretty straight forward first stab at it, but here we go: |
@GrahamcOfBorg test mailcatcher |
ofBorg seems to apply this properly on the current master, I get the same error locally when rebasing your branch onto
|
Will investigate. |
Also, I'd like to avoid having GCC in the mailcatcher closure but I think it happens at a lower level (e.g. in the bundlerApp code) and thus it might be good for another PR/issue |
3d73ba4
to
c1f0a14
Compare
@GrahamcOfBorg test mailcatcher |
@zarelit thanks! |
Motivation for this change
The new release of mailcatcher finally has proper UTF-8 support
Things done
sandbox
innix.conf
on non-NixOS)nix-shell -p nox --run "nox-review wip"
./result/bin/
)nix path-info -S
before and after)