nixos/gnome-settings-daemon: init #56562
Conversation
nixos/modules/services/desktops/gnome3/gnome-settings-daemon.nix
Outdated
Show resolved
Hide resolved
nixos/modules/services/desktops/gnome3/gnome-settings-daemon.nix
Outdated
Show resolved
Hide resolved
|
|
||
| config = mkIf cfg.enable { | ||
|
|
||
| environment.systemPackages = [ cfg.package ]; |
There was a problem hiding this comment.
Do we need this? Neither Elementary or GNOME did this.
There was a problem hiding this comment.
There was a problem hiding this comment.
Why did we not remove it from there?
There was a problem hiding this comment.
I think we only need share/polkit-1/actions linked. We can use pathsToLink for that right?
There was a problem hiding this comment.
That would already be handled by the polkit module.
There was a problem hiding this comment.
Though I think maybe it still should be in gnome3.corePackages because people may depend on it being there.
There was a problem hiding this comment.
using
environment.systemPackages = [ ... ] ++ pkgs.gnome3.corePackages;and not using our gnome3 module.
But that really doesn't matter, I'll remove it from those lists.
There was a problem hiding this comment.
Hmm, I do not consider that part of public interface but Nix does not really help us here. We ought to create a minimal GNOME profile. Something like https://gitlab.com/yegortimoshenko/dotfiles/blob/master/modules/services/gnome3.nix
|
I'm going to follow up with mate using this also, I just had a refactor branch for that module and didn't want to create a conflict. |
Motivation for this change
Not having this kinda bugged me.
And we were going to have anyway, as it was part of #54584.
Only difference from that pr is the
packageoption.I feel this would be a justified case of #50476 because of the forks.
Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)