Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

qtbase: let build use gold linker if it wants, maybe works now #56561

Merged
merged 1 commit into from Mar 1, 2019

Conversation

dtzWill
Copy link
Member

@dtzWill dtzWill commented Mar 1, 2019

Motivation for this change

Remove configure flags forcing qtbase to not use gold linker,
inspired by comment above the flag indicating this is likely specific
to binutils 2.28 (we're currently on 2.31).

Builds for me as does the package set for my day-to-day NixOS system,
so if there's a problem it's not causing complete breakage.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@dtzWill dtzWill requested a review from ttuegel as a code owner March 1, 2019 04:35
@dtzWill
Copy link
Member Author

dtzWill commented Mar 1, 2019

cc @bkchr @adisbladis (author and sign-off on commit adding flags to disable using gold linker here)

Err, this commit: 7132cbd :)

@bkchr
Copy link
Contributor

bkchr commented Mar 1, 2019

If it now works, we probably can enable it again :)

@dtzWill dtzWill merged commit e30d887 into NixOS:staging Mar 1, 2019
@dtzWill dtzWill deleted the feature/qtbase-gold-linker-is-okay branch March 1, 2019 16:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants