Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

nix-prefetch-github: 2.1 -> 2.2 #56542

Merged
merged 1 commit into from Mar 1, 2019
Merged

nix-prefetch-github: 2.1 -> 2.2 #56542

merged 1 commit into from Mar 1, 2019

Conversation

seppeljordan
Copy link
Contributor

@seppeljordan seppeljordan commented Feb 28, 2019 •
edited

Motivation for this change

The upstream version of this package had a major bug, this patch corrects that. I am sorry for the noise (3 releases in 2 weeks). I wrote a test upstream to check for major fuck ups in the future.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@ryantm
Copy link
Member

ryantm commented Mar 1, 2019

@GrahamcOfBorg build nix-prefetch-github

@ryantm ryantm merged commit 934b2a8 into NixOS:master Mar 1, 2019
@ryantm
Copy link
Member

ryantm commented Mar 1, 2019

Thanks!

@ryantm
Copy link
Member

ryantm commented Mar 1, 2019

@seppeljordan Should we backport this to 19.03?

@seppeljordan
Copy link
Contributor Author

@ryantm Yes, that would be nice. Should I just submit a PR for the 19.03 release branch myself?

@ryantm
Copy link
Member

ryantm commented Mar 4, 2019

@seppeljordan yes, that's probably the best way

@seppeljordan seppeljordan deleted the bump-nix-prefetch-github-version branch March 7, 2019 20:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@seppeljordan @ryantm @GrahamcOfBorg