Sage python upgrade fixes #56781
Merged
Sage python upgrade fixes #56781
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
pip 19 introduced a deprecation warning for python 2.7. Since sage internally uses pip to query for installed packages, this deprecation warning will show up at unexpected times. That is ugly and messes with the testsuite. Upstream: https://trac.sagemath.org/ticket/27405
timokau
commented
Mar 3, 2019
| ]; | ||
|
|
||
| buildInputs = [ | ||
| gd | ||
| readline | ||
| iml |
There was a problem hiding this comment.
@FRidh I don't understand why I need to add iml to buildInputs to make the build succeed. Its already in nativeBuildInputs, yet the build fails without it also being in buildInputs.
timokau
commented
Mar 3, 2019
| @@ -58,6 +58,10 @@ buildPythonPackage rec { | |||
| tidyr | |||
| ]) ++ extraRPackages ++ rWrapper.recommendedPackages; | |||
|
|
|||
| nativeBuildInputs = [ | |||
| R # needed at setup time to detect R_HOME (alternatively set R_HOME explicitly) | |||
There was a problem hiding this comment.
@matthewbauer what is the right way to do this? This is probably wrong right? It would pick up the build R and not be able to find it at runtime.
|
Merging this right now to fix the current build failure. After feedback I'll make another PR if necessary. |
|
@timokau sage builds for me on the nixpkgs master, but is still broken on release-19.03. As this seems to fix the build, it should be backported IMHO. |
10 tasks
|
Thanks for reminding me. #57253 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation for this change
Fixes the sage build after it was broken by the pip upgrade &
strictDepsin #55757.Things done
sandboxinnix.confon non-NixOS)nix-shell -p nox --run "nox-review wip"./result/bin/)nix path-info -Sbefore and after)