Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

xpdf: added long description #56601

Merged
merged 1 commit into from Mar 2, 2019
Merged

xpdf: added long description #56601

merged 1 commit into from Mar 2, 2019

Conversation

aakropotkin
Copy link
Contributor

@aakropotkin aakropotkin commented Mar 1, 2019 •
edited

The added description will help folks who are looking for a specific tool to be directed here.
When looking for texttopdf it was a mild hassle to need to turn to google rather than nixpkgs to find the proper package.
When someone else had the same hassle just now in the IRC I thought I'd add this to help remedy others who are searching.

Motivation for this change
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aakropotkin
Added long description
b8f4320 
The added description will help folks who are looking for a specific tool to be directed here.
When looking for `texttopdf` it was a mild hassle to need to turn to google rather than nixpkgs to find the proper package.
When someone else had the same hassle just now in the IRC I thought I'd add this to help remedy others who are searching.
@7c6f434c 7c6f434c changed the title Added long description xpdf: added long description Mar 2, 2019
@7c6f434c 7c6f434c merged commit 2497e71 into NixOS:master Mar 2, 2019
@7c6f434c
Copy link
Member

7c6f434c commented Mar 2, 2019

Thanks, explicit documentation is always nice.

In future, please include the package names into commit messages. (see CONTRIBUTING.md link in the template)

@aakropotkin
Copy link
Contributor Author

Thanks, explicit documentation is always nice.

In future, please include the package names into commit messages. (see CONTRIBUTING.md link in the template)

Thanks for the tip, I will start looking at CONTRIBUTING for better commit messages from now on.

@aakropotkin aakropotkin deleted the patch-1 branch March 12, 2019 23:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aakropotkin @7c6f434c @GrahamcOfBorg