Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

metrics.nix: add nix-env.qaCountDrv metric #56201

Merged
merged 1 commit into from Mar 1, 2019
Merged

metrics.nix: add nix-env.qaCountDrv metric #56201

merged 1 commit into from Mar 1, 2019

Conversation

oxij
Copy link
Member

@oxij oxij commented Feb 22, 2019

git log

  • metrics.nix: add nix-env.qaCountDrv metric

    Before ae16dd1 nix-env.qaCount and
    nix-env.qaCountDrv were equivalent, after that change that is no longer
    the case so this needs a separate metric now.

nix-instantiate environment

  • Host OS: Linux 4.9, SLNOS 19.03
  • Nix: nix-env (Nix) 2.1.3
  • Multi-user: yes
  • Sandbox: yes
  • NIXPKGS_CONFIG:
{
  checkMeta = true;
  doCheckByDefault = true;
}

nix-env -qaP diffs

  • On x86_64-linux: noop
  • On aarch64-linux: noop
  • On x86_64-darwin: noop

/cc @matthewbauer @7c6f434c

@oxij
metrics.nix: add nix-env.qaCountDrv metric
36aa5b6 
Before ae16dd1 `nix-env.qaCount` and
`nix-env.qaCountDrv` were equivalent, after that change that is no longer
the case so this needs a separate metric now.
@vcunat
Copy link
Member

vcunat commented Feb 22, 2019

Wouldn't it be more meaningful to add the difference instead?

@dtzWill
Copy link
Member

dtzWill commented Feb 22, 2019

Wouldn't it be more meaningful to add the difference instead?

Difference requires context (previous commit? evaluation? on what jobset?) that perhaps is better part of visualization/analysis; metric reports the value at this point. Which IMO is the way to go.

Or do you mean difference between the two metrics reported here? May have missed your meaning, sorry.

@vcunat
Copy link
Member

vcunat commented Feb 22, 2019 •
edited

By "difference" I meant adding qaBroken := qaCount - qaCountDrv instead of adding raw qaCountDrv.

@7c6f434c
Copy link
Member

@vcunat I wonder whether resource usage (provided no refactorings happen) tracks qaCount or qaCountDrv better.

@vcunat
Copy link
Member

vcunat commented Feb 22, 2019

For now the difference is fairly small, so I don't think it matters in practice.

@oxij
Copy link
Member Author

oxij commented Feb 23, 2019

@vcunat I'm fine either way. If you think qaBroken is better, then let's do that.

@vcunat vcunat self-assigned this Mar 1, 2019
vcunat added a commit that referenced this pull request Mar 1, 2019
@vcunat
Merge #56201: add nix-env.qaCountBroken metric
e9b11fa 
... into release-19.03.  (Cherry-picked from 35cf2c8.)
The branch is affected by the stdenv change differentiating the numbers,
and I believe consistency with master will be good here.
@vcunat vcunat merged commit 36aa5b6 into NixOS:master Mar 1, 2019
@vcunat
Copy link
Member

vcunat commented Mar 1, 2019

Modified and merged:

nix-env.qaCount 20991
nix-env.qaCountBroken 1230

vcunat added a commit that referenced this pull request Mar 1, 2019
@vcunat
Merge #56201: add nix-env.qaCountBroken metric
35cf2c8
@oxij
Copy link
Member Author

oxij commented Mar 5, 2019 via email

@oxij oxij deleted the tree/qacountdrv-metric branch August 12, 2023 09:06
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@7c6f434c 7c6f434c 7c6f434c approved these changes

Assignees

@vcunat vcunat

Labels
10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@oxij @vcunat @dtzWill @7c6f434c @GrahamcOfBorg