Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 71a59af06187
Choose a base ref
...
head repository: NixOS/nixpkgs
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: e9b11fa20ecb
Choose a head ref
  • 3 commits
  • 1 file changed
  • 2 contributors

Commits on Feb 22, 2019

  1. metrics.nix: add nix-env.qaCountDrv metric 

    Before ae16dd1 `nix-env.qaCount` and
`nix-env.qaCountDrv` were equivalent, after that change that is no longer
the case so this needs a separate metric now.
    @oxij
    oxij committed Feb 22, 2019
    Copy the full SHA
    36aa5b6 View commit details

Commits on Mar 1, 2019

  1. metrics.nix: track qaCountBroken instead of qaCountDrv 

    From these three values, I believe it's most meaningful to track
one of the higher ones and their difference (qaCountBroken).
It's a bit unclear which of the higher ones - I have no data on that,
so I kept the one used before the parent commit.
    @vcunat
    vcunat committed Mar 1, 2019
    Copy the full SHA
    a593f64 View commit details

  2. Merge #56201: add nix-env.qaCountBroken metric 

    ... into release-19.03.  (Cherry-picked from 35cf2c8.)
The branch is affected by the stdenv change differentiating the numbers,
and I believe consistency with master will be good here.
    @vcunat
    vcunat committed Mar 1, 2019
    Copy the full SHA
    e9b11fa View commit details
Showing with 4 additions and 0 deletions.
  1. +4 −0 pkgs/top-level/metrics.nix
4 changes: 4 additions & 0 deletions pkgs/top-level/metrics.nix
View file
Original file line number Diff line number Diff line change
@@ -52,8 +52,12 @@ runCommand "nixpkgs-metrics"
run nix-env.qa nix-env -f ${nixpkgs} -qa
run nix-env.qaDrv nix-env -f ${nixpkgs} -qa --drv-path --meta --xml
# It's slightly unclear which of the set to track: qaCount, qaCountDrv, qaCountBroken.
num=$(nix-env -f ${nixpkgs} -qa | wc -l)
echo "nix-env.qaCount $num" >> $out/nix-support/hydra-metrics
qaCountDrv=$(nix-env -f ${nixpkgs} -qa --drv-path | wc -l)
num=$((num - $qaCountDrv))
echo "nix-env.qaCountBroken $num" >> $out/nix-support/hydra-metrics
# TODO: this has been ignored for some time
# GC Warning: Bad initial heap size 128k - ignoring it.