Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Feature: Move players to company accepting take-over offer. #7315

Closed
wants to merge 1 commit into from
Closed

Feature: Move players to company accepting take-over offer. #7315

wants to merge 1 commit into from

Conversation

SamuXarick
Copy link
Contributor

https://www.tt-forums.net/viewtopic.php?p=1201341#p1201341

Adds a company setting which allows to move the players of the offering company to the purchasing company when the company accepts the take-over offer.

When loading savegames before this patch, set it to disabled for each company.
Defaulted to disabled.

@TrueBrain
Copy link
Member

I see two issues with this PR, from a functional perspective:

  • If we would be to do this, I would expect I can say this during liquidation. Having it a generic setting would be surprising in many cases. After all, the players controlling the company failed to make a profitable company. Chances are slim they will be an asset to your company
  • Gameplay-wise, having this ability is weird. The company went bankrupt for a reason. Why would you also take over the people controlling the company. And why is the serving dictating this.

In other words, we should not be implementing this solution. Things that might be worth exploring, as alternative solution:

  • Bankrupt window showing: yes / yes-with-players / no
  • Possibility to invite spectators to join your company

Anyway, tnx for the contribution; sadly, this is not a solution we are going with.

@TrueBrain TrueBrain closed this Mar 3, 2019
@TrueBrain TrueBrain added the won't implement This change has been rejected label Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
won't implement This change has been rejected
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@SamuXarick @TrueBrain