Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

pythonPackages.protobuf: propagate native pkgs.protobuf input #56761

Merged
merged 1 commit into from Mar 3, 2019

Conversation

delroth
Copy link
Contributor

@delroth delroth commented Mar 3, 2019

Motivation for this change

Python packages depending on the protobuf library often use the "protoc" tool from pkgs.protobuf to codegen at build time. It thus makes sense to propagate that native dependency automatically from the Python lib.

Fixes python3Packages.trezor not building in master nixpkgs.

@FRidh since you changed this last, any thoughts?

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Python packages depending on the protobuf library often use the "protoc"
tool from pkgs.protobuf to codegen at build time.

This fixes a few regressions from 5c75318
@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

Thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants