Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pythonPackages.odfpy: fix build #56619

Closed
wants to merge 1 commit into from
Closed

pythonPackages.odfpy: fix build #56619

wants to merge 1 commit into from

Conversation

jonafato
Copy link
Contributor

@jonafato jonafato commented Mar 2, 2019

Motivation for this change

As of 1.4.0, odfpy requires defusedxml. Details in the version
bump and pull request.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@jonafato
pythonPackages.odfpy: fix build
4b79524 
As of 1.4.0, `odfpy` requires `defusedxml`. Details in the [version
bump] and [pull request].

[verion bump]: eea/odfpy@85d8f40
[pull request]: eea/odfpy#81
@jonafato jonafato requested a review from FRidh as a code owner March 2, 2019 00:54
@FRidh
Copy link
Member

FRidh commented Mar 2, 2019

@GrahamcOfBorg build pythonPackages.odfpy python3Packages.odfpy

@FRidh FRidh self-assigned this Mar 2, 2019
jokogr
jokogr approved these changes Mar 2, 2019
View reviewed changes
Copy link
Contributor

@jokogr jokogr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

calibre was broken before in unstable, I managed to build and run it with this one.

@FRidh
Copy link
Member

FRidh commented Mar 3, 2019

Seems like 434c2a0 has gone in in the meanwhile.

@FRidh FRidh closed this Mar 3, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jokogr jokogr jokogr approved these changes

@FRidh FRidh Awaiting requested review from FRidh

Assignees

@FRidh FRidh

Labels
6.topic: python 10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@jonafato @FRidh @jokogr @GrahamcOfBorg