Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

firefox 65.0.2 -> 66, 60.5.2esr -> 60.6.0esr, firefox-bin: 65.0.2 -> 66.0 #56689

Merged
merged 6 commits into from Mar 18, 2019
Merged

firefox 65.0.2 -> 66, 60.5.2esr -> 60.6.0esr, firefox-bin: 65.0.2 -> 66.0 #56689

merged 6 commits into from Mar 18, 2019

Conversation

andir
Copy link
Member

@andir andir commented Mar 2, 2019 •
edited

Motivation for this change

FireFox 66 will be released today. The final tarball is already released and the binaries are build.

Changelog is not yet available but should be at:

https://www.mozilla.org/en-US/firefox/66.0/releasenotes/
and
https://www.mozilla.org/en-US/firefox/60.6.0/releasenotes/

@andir
Copy link
Member Author

andir commented Mar 2, 2019

@GrahamcOfBorg eval
@GrahamcOfBorg build rust-cbindgen

@andir andir force-pushed the firefox66 branch 3 times, most recently from c5c5c1d to 30b0f3a Compare March 14, 2019 14:00
@andir andir marked this pull request as ready for review March 18, 2019 16:26
@andir andir added the 9.needs: port to stable A PR needs a backport to the stable release. label Mar 18, 2019
@andir andir mentioned this pull request Mar 18, 2019
Merged
10 tasks
@andir andir changed the title firefox66 build support firefox 65.0.2 -> 66, 60.5.2esr -> 60.6.0esr, firefox-bin: 65.0.2 -> 66.0 Mar 18, 2019
@Mic92
Copy link
Member

Mic92 commented Mar 18, 2019

Anything particular to test?

nix-review pr 56689
$ git fetch --force https://github.com/NixOS/nixpkgs master:refs/nix-review/0 pull/56689/head:refs/nix-review/1
remote: Enumerating objects: 8590, done.
remote: Counting objects: 100% (8590/8590), done.
remote: Compressing objects: 100% (10/10), done.
remote: Total 17401 (delta 8579), reused 8585 (delta 8579), pack-reused 8811
Receiving objects: 100% (17401/17401), 10.65 MiB | 16.77 MiB/s, done.
Resolving deltas: 100% (12569/12569), completed with 2530 local objects.
From https://github.com/NixOS/nixpkgs
   538ce21fe8e..f5c63cbb54f  master               -> refs/nix-review/0
 + 1e8d1d0fd5e...94d9400b4d6 refs/pull/56689/head -> refs/nix-review/1  (forced update)
$ git worktree add /home/s1691654/.cache/nix-review/pr-56689/nixpkgs f5c63cbb54fa64c4889b07e7c7f2ae85ca3d5ce4
Preparing worktree (detached HEAD f5c63cbb54f)
HEAD is now at f5c63cbb54f Merge pull request #57018 from andir/davix
$ git merge --no-commit 94d9400b4d65de02af8cb421d8e85698a7f7246d
Automatic merge went well; stopped before committing as requested
$ nix build --no-link --keep-going --max-jobs 72 --option build-use-sandbox true -f /home/s1691654/.cache/nix-review/pr-56689/build.nix
[5/22/35 built, 362 copied (5301.9/5303.4 MiB), 1393.8 MiB DL] building firefox-unwrapped-66.0 (buildPhase): /nix/store/ghzg4kg0sjif58smj2lfm2bdvjwim85y-gcc-wrapper-7.4.0/bin/g++ -o nsHttpHan[5/22/35 built, 362 copied (5301.9/5303.4 MiB), 1393.8 MiB DL] building firefox-unwrapped-66.0 (buildPhase): /nix/store/ghzg4kg0sjif58smj2lfm2bdvjwim85y-gcc-wrapper-7.4.0/bin/g++ -o s_trunc.o[5/22/35 built, 362 copied (5301.9/5303.4 MiB), 1393.8 MiB DL] building firefox-unwrapped-66.0 (buildPhase): /build/firefox-66.0/gfx/skia/skia/src/core/SkPixmap.cpp:236:15: warning: this stat[5/22/35 built, 362 copied (5301.9/5303.4 MiB), 1393.8 MiB DL] building tor-browser-unwrapped-7.5.6 (buildPhase): /nix/store/ghzg4kg0sjif58smj2lfm2bdvjwim85y-gcc-wrapper-7.4.0/bin/gcc -std=gn[35 built, 362 copied (5301.9 MiB), 1393.8 MiB DL]
https://github.com/NixOS/nixpkgs/pull/56689
3 package are marked as broken and were skipped:
firefox-esr-52-unwrapped firefoxPackages.firefox-esr-52 firefoxPackages.icecat-52

14 package were build:
chatzilla conkeror-unwrapped dropbox dropbox-cli firefox-bin-unwrapped firefox-esr-60-unwrapped xulrunner icecat-unwrapped tor-browser-unwrapped firefoxPackages.tor-browser-7-5 icedtea_web mozplugger rust-cbindgen slimerjs

$ nix-shell /home/s1691654/.cache/nix-review/pr-56689/shell.nix
bash: /tmp/env-vars: cannot overwrite existing file

@andir
Copy link
Member Author

andir commented Mar 18, 2019

Test if they work as browser :)

As for all the packages that will be built as a side-effect they should be fine if the firefox's work.

@Mic92
Copy link
Member

Mic92 commented Mar 18, 2019

Sent with firefox 66.

@7c6f434c 7c6f434c merged commit 0f3146e into NixOS:master Mar 18, 2019
@andir andir deleted the firefox66 branch March 18, 2019 20:05
@andir andir mentioned this pull request Mar 19, 2019
Merged
10 tasks
@samueldr samueldr removed the 9.needs: port to stable A PR needs a backport to the stable release. label Apr 17, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtojnar jtojnar Awaiting requested review from jtojnar

@edolstra edolstra Awaiting requested review from edolstra

Assignees
No one assigned
Labels
10.rebuild-darwin: 11-100 10.rebuild-linux: 11-100 11.by: package-maintainer
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
5 participants
@andir @Mic92 @samueldr @7c6f434c @GrahamcOfBorg