Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

pugixml: Fix pkg-config file installation and use fetchFromGitHub #56692

Merged
merged 2 commits into from Mar 3, 2019
Merged

pugixml: Fix pkg-config file installation and use fetchFromGitHub #56692

merged 2 commits into from Mar 3, 2019

Conversation

jokogr
Copy link
Contributor

@jokogr jokogr commented Mar 2, 2019

Motivation for this change

FileZilla was not building (#56505) and tracked it down to a pugixml change (#56351).

Tested this by building FileZilla.

cc @pSub

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@GrahamcOfBorg GrahamcOfBorg requested a review from pSub March 2, 2019 12:31
@pSub
Copy link
Member

pSub commented Mar 2, 2019

@GrahamcOfBorg build filezilla

@pSub pSub merged commit c318db2 into NixOS:master Mar 3, 2019
@jokogr jokogr deleted the f/pugixml-1.9 branch March 7, 2019 14:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@pSub pSub pSub approved these changes

Assignees
No one assigned
Labels
10.rebuild-darwin: 1-10 10.rebuild-linux: 1-10
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@jokogr @pSub @GrahamcOfBorg