Skip to content

youtrack: add hostname to path #56578

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Mar 7, 2019
Merged

youtrack: add hostname to path #56578

merged 1 commit into from
Mar 7, 2019
+1 −0

Conversation

yorickvP
Copy link
Contributor

@yorickvP yorickvP commented Mar 1, 2019 •
edited
Loading

Motivation for this change

Youtrack is complaining about a missing hostname. This is probably unimportant, but easily fixable.

Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

Sorry, something went wrong.

@yorickvP yorickvP requested a review from infinisil as a code owner March 1, 2019 14:17
@GrahamcOfBorg GrahamcOfBorg added 6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux labels Mar 1, 2019
@infinisil
Copy link
Member

Please format your commit message according to the Contribution Guidelines, also linked to from the PR template.

@yorickvP yorickvP force-pushed the youtrack-hostname branch from 13ed504 to c568dad Compare March 7, 2019 16:23
@yorickvP
Copy link
Contributor Author

yorickvP commented Mar 7, 2019

Thanks, this looked like a package change at first glance.

@infinisil infinisil merged commit 34e67f3 into NixOS:master Mar 7, 2019
adrianpk added a commit to adrianpk/nixpkgs that referenced this pull request May 31, 2024
@adrianpk
Merge pull request NixOS#56578 from serokell/youtrack-hostname
ca1083d 
youtrack: add hostname to path
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil

Assignees
No one assigned
Labels
6.topic: nixos Issues or PRs affecting NixOS modules, or package usability issues specific to NixOS 8.has: module (update) This PR changes an existing module in `nixos/` 10.rebuild-darwin: 0 This PR does not cause any packages to rebuild on Darwin 10.rebuild-linux: 0 This PR does not cause any packages to rebuild on Linux
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@yorickvP @infinisil @GrahamcOfBorg