Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

set phpOptions per phpfpm pool, instead of applying to every phpfpm pool #56625

Merged
merged 1 commit into from Mar 8, 2019
Merged

set phpOptions per phpfpm pool, instead of applying to every phpfpm pool #56625

merged 1 commit into from Mar 8, 2019

Conversation

aanderse
Copy link
Member

@aanderse aanderse commented Mar 2, 2019

Motivation for this change

A follow up to #55742 which better sandboxes phpfpm pools, allowing for more reproducible systems.

  • @peterhoeg I've never used zoneminder and there isn't a nixos test - can you test and/or do you approve?
  • @dasJ I've never used icingaweb2 and there isn't a nixos test - can you test and/or do you approve?
  • @ts468 I've never used restya-board and there isn't a nixos test - can you test and/or do you approve?
Things done
  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@aanderse aanderse requested a review from infinisil as a code owner March 2, 2019 01:31
@aanderse
nixos/icingaweb2, nixos/restya-board, nixos/zoneminder: set phpOption…
cddb117 
…s per phpfpm pool, instead of applying to every phpfpm pool
@infinisil infinisil merged commit 4a9a596 into NixOS:master Mar 8, 2019
@aanderse aanderse deleted the phpfpm branch March 8, 2019 01:32
@Slabity Slabity mentioned this pull request Jun 14, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@infinisil infinisil infinisil approved these changes

Assignees
No one assigned
Labels
6.topic: nixos 8.has: module (update) 10.rebuild-darwin: 0 10.rebuild-linux: 0
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@aanderse @infinisil @GrahamcOfBorg