Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Codechange: Make std::stack use std::vector container in string formatting/drawing. #7305

Merged
merged 1 commit into from Mar 2, 2019

Conversation

PeterN
Copy link
Member

@PeterN PeterN commented Mar 2, 2019

This is a very minor performance increase which can add up during operations such
as sorting. Performance impact my be platform/compiler dependent.

When sorting a list of 32k signs in the sign window, the following timings were noted:

  • In master: 200-400ms/t
  • With this change: 64-96ms/t

…tting/drawing.

This is a very minor performance increase which can add up during operations such
as sorting. Performance impact my be platform/compiler dependent.
Copy link
Contributor

@nielsmh nielsmh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I told you it would help ;)

@PeterN PeterN merged commit 63fe6c6 into OpenTTD:master Mar 2, 2019
@PeterN PeterN deleted the std-stack-use-std-vector branch March 2, 2019 08:06
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this pull request Mar 11, 2019
…tting/drawing. (OpenTTD#7305)

This is a very minor performance increase which can add up during operations such
as sorting. Performance impact my be platform/compiler dependent.
douiwby pushed a commit to douiwby/OpenTTD that referenced this pull request Apr 16, 2020
…tting/drawing. (OpenTTD#7305)

This is a very minor performance increase which can add up during operations such
as sorting. Performance impact my be platform/compiler dependent.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants