Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

t450s: fix trackpoint configuration at boot #102

Closed
wants to merge 1 commit into from

Conversation

ashkitten
Copy link

as i discussed in detail in this issue on nixpkgs, the t450s (and likely other models) have a problem where they do not create the sysfs attributes for the trackpoint device early enough in the boot process for udev to configure them. this pull request adds a (sadly device-specific) method for triggering udev to configure the device once the sysfs path appears.


systemd.paths.trackpoint = {
pathConfig = {
PathExists = "/sys/devices/rmi4-00/rmi4-00.fn03/serio2";
Copy link
Member

@Mic92 Mic92 Mar 4, 2019

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could you also add a brief comment here, what this line does as you did in the pr description? Otherwise looks good to me.

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

yeah np, i'll add that when i've got my t450s back in a working state (i've had to order a replacement touchpad for unrelated reasons)

@ashkitten
Copy link
Author

by the way, i'd like to be able to reuse this code without copy-paste for other devices that need it, but i don't know nix well enough to know do that (obviously the device path could be different)

@Mic92
Copy link
Member

Mic92 commented Mar 8, 2019

You can just put it into a different file and use the imports feature.
In case other models require modifications, you can also create an option for that like here: https://github.com/Mic92/dotfiles/blob/master/nixos/vms/modules/retiolum.nix

@ashkitten
Copy link
Author

hi, sorry to say i won't be able to work on this pull request and help it to be merged as i would feel bad abandoning it afterwards. my touchpad and by extension trackpoint is Officially Not Working anymore and i've not been able to repair it.

@ashkitten ashkitten closed this Mar 16, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants