Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Inconsistent detection of coast tiles #7307

Closed
andythenorth opened this issue Mar 2, 2019 · 1 comment
Closed

Inconsistent detection of coast tiles #7307

andythenorth opened this issue Mar 2, 2019 · 1 comment

Comments

@andythenorth
Copy link
Contributor

Version of OpenTTD

c700b0c

Expected result

Consistent detection of coast tiles when placing newgrf industry.

Actual result

Frequently, but inconsistently, coast tiles aren't detected correctly.

Bulldozing the tiles resolves the issue.

Steps to reproduce

Try building a Bulk Terminal in FIRS 3, along a straight run of SE coast (easiest placement).

Occasionally this won't be permitted. Then bulldoze the 4 coast tiles for the location. Then building will be permitted.

This might be due to some other tile var, not coast detection. Or it could easily be a bug in FIRS or nmlc. But it looks to me like some tile prop isn't set correctly.

Been present for a long time, causes issues placing these and similar industries at map-gen.

coast_bug_1

coast_bug_2

coast_bug_3
@andythenorth
Copy link
Contributor Author

andythenorth commented Mar 2, 2019 •
edited

In at least some cases, this is explained by one or more of the coast tiles having trees on it. Land info tool in those cases reports 'Trees' rather than 'Coast or Riverbank' (I didn't notice trees visually as I always have trees invisible).

Trees shouldn't block industry construction IMO, but this is at least consistently reproducible.

I will investigate further, and probably retitle this issue.

Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Mar 2, 2019
@Eddi-z
Fix OpenTTD#7307: Add WaterClass to MP_TREES
924e4be
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Mar 2, 2019
@Eddi-z
Fix OpenTTD#7307: Add WaterClass to MP_TREES
6609620
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Mar 2, 2019
@Eddi-z
Fix OpenTTD#7307: Add WaterClass to MP_TREES
fae9b57
Eddi-z added a commit to Eddi-z/OpenTTD that referenced this issue Mar 2, 2019
@Eddi-z
Fix OpenTTD#7307: Add WaterClass to MP_TREES
29fe66c
@PeterN PeterN closed this as completed in b242a04 Mar 2, 2019
nielsmh pushed a commit to nielsmh/OpenTTD that referenced this issue Mar 11, 2019
@Eddi-z @nielsmh
Fix OpenTTD#7307: Add WaterClass to MP_TREES, set when trees are on c…
a4f2c31 
…oast tiles (OpenTTD#7309)

This allows allows NewGRF object/industry placement rules to treat trees on coast tiles the same as regular bare coast.
PeterN added a commit to PeterN/OpenTTD that referenced this issue Mar 24, 2019
@PeterN
Revert "Fix OpenTTD#7307: Add WaterClass to MP_TREES, set when trees …
b44b462 
…are on coast tiles (OpenTTD#7309)"

This reverts commit b242a04.
PeterN added a commit to PeterN/OpenTTD that referenced this issue Mar 24, 2019
@PeterN
Fix OpenTTD#7307: Treat trees on coast as water tiles for industry pl…
c37e937 
…acement rules.
douiwby pushed a commit to douiwby/OpenTTD that referenced this issue Apr 16, 2020
@Eddi-z @douiwby
Fix OpenTTD#7307: Add WaterClass to MP_TREES, set when trees are on c…
98c91c6 
…oast tiles (OpenTTD#7309)

This allows allows NewGRF object/industry placement rules to treat trees on coast tiles the same as regular bare coast.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@andythenorth