Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

nixos/manual: fix build #56685

Merged
merged 1 commit into from Mar 2, 2019
Merged

nixos/manual: fix build #56685

merged 1 commit into from Mar 2, 2019

Conversation

pbogdan
Copy link
Member

@pbogdan pbogdan commented Mar 2, 2019

Motivation for this change

NixOS manual and man pages don't build at the moment.

/cc @srhb @LnL7

Things done
  • nix-build nixos/release-combined.nix -A nixos.manpages.x86_64-linux
  • nix-build nixos/release-combined.nix -A nixos.manual.x86_64-linux

  • Tested using sandboxing (nix.useSandbox on NixOS, or option sandbox in nix.conf on non-NixOS)
  • Built on platform(s)
    • NixOS
    • macOS
    • other Linux distributions
  • Tested via one or more NixOS test(s) if existing and applicable for the change (look inside nixos/tests)
  • Tested compilation of all pkgs that depend on this change using nix-shell -p nox --run "nox-review wip"
  • Tested execution of all binary files (usually in ./result/bin/)
  • Determined the impact on package closure size (by running nix path-info -S before and after)
  • Assured whether relevant documentation is up to date
  • Fits CONTRIBUTING.md.

@terlar
Copy link
Contributor

terlar commented Mar 2, 2019

I ran into this issue as well.

@srhb
Copy link
Contributor

srhb commented Mar 2, 2019

Oops, sorry. I'll let gcofborg eval here first.

@srhb
Copy link
Contributor

srhb commented Mar 2, 2019

Needs a backport to 19.03 as well. I'll do that.

@srhb
Copy link
Contributor

srhb commented Mar 2, 2019

Backport to 19.03 in 697213d

@pbogdan pbogdan deleted the manual-build branch March 2, 2019 11:18
@LnL7
Copy link
Member

LnL7 commented Mar 2, 2019

Whoops, did I break that?

@srhb
Copy link
Contributor

srhb commented Mar 2, 2019

@LnL7 Well, I clearly thought I was able to review / parse XML in my head, so... ;)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants